Topo Naming PR 2 #7435
Merged
Topo Naming PR 2 #7435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExtensionContainer::foreach/query/callExtension()
Make use of the shadow subname (i.e. the new topo naming) stored inside PropertyLinkSubList for more robust geometry element referecing. And rely on Part::Feature::getRelatedElements() to deduce missing geometry elements.
Most of the new topo naming code can be disabled by defining Macro FC_NO_ELEMENT_MAP
Used in TaskElementColors for general handling of per geometry element coloring.
The re-tagging is necessary for trace geometry element history to linked object, which is required for Part::ViewProviderPartExt color mapping.
github-actions
bot
added
Core
error: ambiguous overload for ‘operator==’ (operand types are ‘App::StringHasher* const’ and ‘const StringHasherRef’ {aka ‘const Base::Reference<App::StringHasher>’})
|
I will merge now and make the announcement hopefully next Sunday when am back home. |
|
The CI reports some things that might be of interest, see section "Unchanged files with check annotations": |
|
For those on Linux who are OK with using Snap packages, it's possible to test @realthunder's toponaming patches via: |
tritao
reviewed
Sep 11, 2022
| @@ -2501,7 +2513,12 @@ class Module : public Py::ExtensionModule<Module> | |||
| &mat,&subObj,retType==2,PyObject_IsTrue(transform) ? true : false, | |||
| PyObject_IsTrue(noElementMap) ? true : false); | |||
| if (PyObject_IsTrue(refine) ? true : false) { | |||
| #ifndef FC_NO_ELMENT_MAP | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second batch of patches for the new Topo Naming of geometry elements. It adds code to the features from Part workbench for generating Topo Naming using the new APIs. At this stage, the end-user can see the new Topo Naming in action by testing various features from Part workbench. Only features from Part workbench are supported. And if sketch is involved (e.g. Extrusion from a sketch), then try not to modify the sketch for the purpose of Topo Naming testing until the next batch of patches is in.