Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Spreadsheet settings in user.cfg do not work #7582

Open
2 tasks done
Tracked by #6805
MisterMakerNL opened this issue Oct 9, 2022 · 8 comments
Open
2 tasks done
Tracked by #6805

[Bug] Spreadsheet settings in user.cfg do not work #7582

MisterMakerNL opened this issue Oct 9, 2022 · 8 comments
Labels
3rd party: Qt Missing: feedback If feedback is requested Stylesheets Anything regarding stylesheets/themes UI/UX WB Spreadsheet Related to the Spreadsheet Workbench

Comments

@MisterMakerNL
Copy link
Contributor

MisterMakerNL commented Oct 9, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Forums discussion

https://forum.freecad.org/viewtopic.php?f=34&t=72294&start=10

Version

0.21 (Development)

Full version info

So after trying to adjust the colors in Spreadsheet by qss theme file and failed I tried do do it with the preference pack cfg file and I also failed.
I tried to modify the settings in the user.cfg file, but that didn't do anything also. So I have to conclude it is broken. I tested it on 0.21 and 0.20.1 on Windows 10.
Below code that was in the user.cfg I modified.

          <FCParamGroup Name="Spreadsheet">
            <FCInt Name="aliasBgColor" Value="746455039"/>
            <FCUInt Name="textFgColor" Value="746455039"/>
            <FCUInt Name="positiveFgColor" Value="2105376255"/>
            <FCUInt Name="negativeFgColor" Value="4294967295"/>
            <FCText Name="ImportExportDelimiter">tab</FCText>
            <FCText Name="ImportExportQuoteCharacter">I</FCText>
            <FCText Name="ImportExportEscapeCharacter">F</FCText>
            <FCUInt Name="aliasBgColor" Value="2105376255"/>
            <FCUInt Name="AliasedCellBackgroundColor" Value="11141375"/>
          </FCParamGroup>

Also relevant:
#6805 (comment)

Subproject(s) affected?

No response

Issue description

Trying to modify the alias background color and the text color of spreadsheets, but it seems to be broken.

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added UI/UX Stylesheets Anything regarding stylesheets/themes WB Spreadsheet Related to the Spreadsheet Workbench 3rd party: Qt labels Oct 9, 2022
@luzpaz
Copy link
Contributor

luzpaz commented Oct 15, 2022

@chennes can I assign this to you?

@chennes
Copy link
Member

chennes commented Oct 15, 2022

The bug is wrong: the data type of the alias color is FCText, not FCUint.

@luzpaz
Copy link
Contributor

luzpaz commented Oct 15, 2022

@MisterMakerNL ☝️

@luzpaz luzpaz added the Missing: feedback If feedback is requested label Oct 15, 2022
@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Oct 16, 2022

@luzpaz Yeah, the bug is wrong but kinda doesn't matter since it is still bugged.
The current work around is adding this line to your preference pack:
<FCText Name="AliasedCellBackgroundColor">#850097</FCText>
The issue is that it doesn't get reset anywhere so if you switch back to no stylesheet or no preference pack it stays that color.
Workaround for that currently is apply my "ExtremeProLight" since that resets it too the yellow color.

The bug is that the settings in the user.cfg are not FCtext and use the wrong parameter. Also adding a tab for colors for spreadsheet would help a lot for this, just like other addons have a color tab.
Also since we are modifying a table here and we are doing that also in the theme .qss file it would be more logical to make it possible to modify it using the .qss file.

@chennes
Copy link
Member

chennes commented Oct 16, 2022

Adding access to those variables to the preferences dialog is relatively simple (though only relatively, because we can't use the built-in color selection widget, which would save the value as a uint!). Switching to using QSS for the styling is a bit more work.

@MisterMakerNL
Copy link
Contributor Author

MisterMakerNL commented Oct 17, 2022

My suggestion would be to make it similar to the rest. So not using text parameters, although using hex is nice having the same workflow for all settings is probably better.

@Intuos5
Copy link

Intuos5 commented Feb 5, 2023

Would be nice to have a colour tab for spreadsheet preferences indeed. Stumbled upon the Aliased cell color issue in my theming efforts as well.

@luzpaz
Copy link
Contributor

luzpaz commented Dec 17, 2023

What's the roadmap here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party: Qt Missing: feedback If feedback is requested Stylesheets Anything regarding stylesheets/themes UI/UX WB Spreadsheet Related to the Spreadsheet Workbench
Projects
None yet
Development

No branches or pull requests

4 participants