Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "File" toolbar and add "Clipboard" toolbar #7620

Merged
merged 2 commits into from Mar 4, 2023

Conversation

adrianinsaval
Copy link
Member

following forum discussions about toolbars, some users would like to have cut/copy/paste in the toolbar, by making it a separate toolbar it is easier to hide for those that don't want it. Same situation with the what's this? command, by making it a separate toolbar it is easily hidden by those not using it.
https://forum.freecadweb.org/viewtopic.php?f=8&t=71924&start=10
https://forum.freecadweb.org/viewtopic.php?p=626197#p626197
The undo/redo/refresh commands where moved into a separate Edit toolbar to be a little more consistent with the menus and to some extent with other software that have this separated, this also makes it easier to customize the location of toolbars, for example I would prefer to have the Structure toolbar between File and Edit. If this is undesired I will revert this portion of the changes.

@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Oct 19, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7620. Pipeline 671228737 was triggered at 15556f7. All CI branches and pipelines.

@luzpaz luzpaz added the UI/UX label Oct 19, 2022
@adrianinsaval adrianinsaval marked this pull request as ready for review October 19, 2022 16:44
@adrianinsaval
Copy link
Member Author

proposed toolbar default layout:
image

@adrianinsaval
Copy link
Member Author

Note to self: update wiki when/if this gets merged

@chennes
Copy link
Member

chennes commented Oct 31, 2022

(Just a note that I'm trying to see how to make a toolbar default to hidden so that this PR doesn't re-add the clipboard buttons that were previously removed).

"File" is split into "File", "Edit" and "Help"
"Clipboard" is hidden by default
@adrianinsaval
Copy link
Member Author

@chennes continuing from forum discussion https://forum.freecadweb.org/viewtopic.php?p=646278#p646278

I think you need to set its "Active" parameter to False.

I did not find such a parameter but I found a way of making a toolbar hidden by default, but it required a few changes to ToolBarManager, please review when you have the time

@freecadci
Copy link

pipeline status for feature branch PR_7620. Pipeline 717645270 was triggered at 357cef2. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_7620. Pipeline 717646864 was triggered at a06c39e. All CI branches and pipelines.

@adrianinsaval
Copy link
Member Author

@chennes friendly reminder

@chennes
Copy link
Member

chennes commented Mar 4, 2023

Sorry this took me so long to get to! I think it's good to go in.

@chennes chennes merged commit 57070b2 into FreeCAD:master Mar 4, 2023
@adrianinsaval adrianinsaval deleted the patch-2 branch March 4, 2023 13:28
@adrianinsaval
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants