Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sketcher] Delete check for OCC >= 6.9.0 #8106

Merged
merged 1 commit into from Jan 4, 2023

Conversation

AjinkyaDahale
Copy link
Contributor

@AjinkyaDahale AjinkyaDahale commented Dec 31, 2022

The oldest version we plan to support is 7.0.0 (which comes with Ubuntu 20.04).

See https://forum.freecadweb.org/viewtopic.php?f=10&p=650487#p650487.

@github-actions github-actions bot added the WB Sketcher Related to the Sketcher Workbench label Dec 31, 2022
@luzpaz
Copy link
Contributor

luzpaz commented Dec 31, 2022

This likely also won't be an issue since most of the package ecosystem has moved to >=7.2.0 (https://repology.org/project/opencascade-occt/badges)

@AjinkyaDahale
Copy link
Contributor Author

@luzpaz that is true, but currently an important library has been removed, which makes the join operation fail (see linked post). We should either merge #8103 or this one (or both).

@luzpaz
Copy link
Contributor

luzpaz commented Dec 31, 2022

@donovaly removed the header in question it looks like.

@AjinkyaDahale
Copy link
Contributor Author

@wwmayer tagging you as well since we are talking about it in that forum thread.

@freecadci
Copy link

pipeline status for feature branch PR_8106. Pipeline 735666308 was triggered at 8ec4bd1. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_8106. Pipeline 735722690 was triggered at 8ec4bd1. All CI branches and pipelines.

@donovaly donovaly merged commit c6b4e5c into FreeCAD:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants