Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Sketcher - resize constraint icons independent from the font size #8288

Open
2 tasks done
Intuos5 opened this issue Jan 28, 2023 · 11 comments
Open
2 tasks done
Labels
Feature FR for improvements or new features Help wanted Solution proposed The issue has a solution proposed UI/UX WB Sketcher Related to the Sketcher Workbench

Comments

@Intuos5
Copy link

Intuos5 commented Jan 28, 2023

Is there an existing request for this?

  • I have searched the existing requests

Forums discussion

https://forum.freecadweb.org/viewtopic.php?style=2&f=10&t=49972&start=70

Subproject(s) affected?

Sketcher

Idea description

I would like to resize the constraint icons independent from the font in the Sketcher workbench. The reason being, the icons are half the size of the font for me. I want to increase the constraint icons to improve readability, but I don't want very large dimension texts, because that deteriorates readability.
Please add a dedicated constraint icon size parameter in the preferences of the Sketcher workbench.

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz
Copy link
Contributor

luzpaz commented Jan 28, 2023

You can attach images to the ticket. Before/After images are welcome.

@Intuos5
Copy link
Author

Intuos5 commented Jan 29, 2023

Don't mind the silly sketch, it's for illustration purposes. Also note that this is on a 27 inch 4k screen.
Text size is correct, constraints are too small (text size is 20):
small

Constraints are readable, but text is too large (text size is 40):
large

This is how I would like it to be (text size is 20, icon size is 40):
preferable

@luzpaz luzpaz added UI/UX Feature FR for improvements or new features WB Sketcher Related to the Sketcher Workbench labels Feb 6, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Feb 6, 2023

Not directly related but in the same vein to #7030

@LancashireDave
Copy link

I use a high res 43" monitor and the icons are so small I can hardly see them. The ability to change the icon size would be a great improvement

@luzpaz
Copy link
Contributor

luzpaz commented Sep 29, 2023

@Syres916 offered a possible solution in master...Syres916:FreeCAD:patch-64

@luzpaz luzpaz added Solution proposed The issue has a solution proposed Help wanted labels Sep 29, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Sep 29, 2023

@PaddleStroke can you review proposed change ?

@PaddleStroke
Copy link
Contributor

PaddleStroke commented Sep 29, 2023

Client.drawingParameters.constraintIconSize = std::lround(sketchericonSizeRatio * 0.8 * sketcherfontSize);
@Syres916 why keeping the dependency to the font size if we introduce a parameter for the size of icons ?

I think if we introduce a setting, we might as well remove the sketcherfontSize from the equation and just use a size preference for the icons.

@adrianinsaval
Copy link
Member

I don't agree with adding a separate preference for this, instead it looks to me like there's a problem with how the text and the symbols are scaling at different rates for this person and it should be fixed to be more sensible. Here's how it scales for me, at 40px:
image
at 20 px:
image

@Intuos5
Copy link
Author

Intuos5 commented Oct 10, 2023

If possible, I would prefer independent scaling of text and icons, because I prefer to set them at scales that make it most comfortable for me. I may want smaller text and larger icons for legibility, others may want the same size, etc.

@adrianinsaval
Copy link
Member

if implemented I would suggest it be through a parameter only, let's not keep polluting preference pages with obscure options to satisfy individual wishes.

@luzpaz
Copy link
Contributor

luzpaz commented Mar 9, 2024

Is this on the 1.0 roadmap ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features Help wanted Solution proposed The issue has a solution proposed UI/UX WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

5 participants