Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] "External geometry" on shapebind ellipse arc recreates the whole ellipse #8700

Open
2 tasks done
CharlesMir opened this issue Feb 28, 2023 · 6 comments
Open
2 tasks done
Labels
Bug This issue or PR is related to a bug Missing: feedback If feedback is requested Status: confirmed The issue was confirmed by others WB Sketcher Related to the Sketcher Workbench
Milestone

Comments

@CharlesMir
Copy link

CharlesMir commented Feb 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Forums discussion

https://forum.freecad.org/viewtopic.php?t=76408

Version

0.20 (Release)

Full version info

[code]
OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.2.29177 +426 (Git)
Build type: Release
Branch: (HEAD detached from 0.20.2)
Hash: 930dd9a76203a3260b1e6256c70c1c3cad8c5cb8
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.3
Locale: French/France (fr_FR)
[/code]

Subproject(s) affected?

Sketcher

Issue description

I would like to do the following :

  1. Shapebind an arc of ellipse from a master sketch (works fine)
  2. Use external geometry on this shapebind in another sketch

The whole ellipse is recreated and not just the arc.

Is this a bug ? It works fine with circular arcs, am I missing something ? (Or Is there a better way to do what I want ?)
I tried the carbon copy function, but it's tricky to manage constraints in derived sketches if some elements in the master sketch are modified/deleted.

Response:

Looks like a bug... Other arcs are properly limited.

To recreate the bug :

  1. Create a sketch with an elliptic arc in it
  2. Create a new body (partdesign) by "shapebinding" the elliptic arc from the previous sketch
  3. Create a new sketch inside this body
  4. Use the tool "External geometry" on the shapebind
  5. BUG : The whole ellipse is recreated and not just the arc.

It seems to be the only type of arc affected.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added the WB Sketcher Related to the Sketcher Workbench label Feb 28, 2023
@fra589
Copy link
Contributor

fra589 commented Jul 10, 2023

Hi all,

There is another forum discussion for what it seams to me the same bug, but without "new body (partdesign) by "shapebinding"":

Forum discusion
https://forum.freecad.org/viewtopic.php?t=79517

Externals elliptical arcs and externals circular arcs are affected by this bug.

Full info version

OS: Debian GNU/Linux 12 (bookworm) (XFCE/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.21.0.33434 (Git)
Build type: Release
Branch: master
Hash: a76105c3d90a03cfccbd5afb5a33a1f48948041f
Python 3.11.2, Qt 5.15.8, Coin 4.0.0, Vtk 9.1.0, OCC 7.7.1
Locale: C/Default (C) [ OS: French/France (fr_FR) ]

first proposal patch (but not complete) here:
master...Syres916:FreeCAD:patch-84

@++;
Gauthier.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 24, 2023

@fra589 the link to the patch is not valid AFAICT

@luzpaz luzpaz added Missing: feedback If feedback is requested Bug This issue or PR is related to a bug Status: confirmed The issue was confirmed by others labels Sep 24, 2023
@luzpaz luzpaz added this to the 1.0 milestone Sep 24, 2023
@fra589
Copy link
Contributor

fra589 commented Sep 25, 2023

@fra589 the link to the patch is not valid AFAICT

The patch link from @Syres916 (proposed in the forum discussion https://forum.freecad.org/viewtopic.php?t=79517) was good in July 07... But not today, probably due to the many updates in the concerned file : FreeCAD/src/Mod/Sketcher/App/SketchObject.cpp

I'm sorry, but I tested it with partial success in July, but I lost it after testing. I seem to remember that the change proposed in the patch was in the SketchObject::rebuildExternalGeometry() function.

Perhaps @Syres916 will remember...

@Syres916
Copy link
Contributor

The reason the link is no longer valid is I'd got too many branches as it is/was and I must have cleared it out due to the lack of recent feedback, sorry but these issues just seem to drag on way too long for the way I'm used to work. I raised the fact that there are somewhere in the region of 150 Sketcher current Issues on the forum when the maintainer returned and there needs to be a priority order but there was no reply to that.

@luzpaz
Copy link
Contributor

luzpaz commented Sep 29, 2023

@Syres916 thanks for all your hard work. I really want to see it addressed seriously as well.

Just a tip, if I may? Perhaps label your branch in a way that you know what issue it's targeting ?

@luzpaz
Copy link
Contributor

luzpaz commented Dec 17, 2023

@PaddleStroke can you take a look at this when you have a moment ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug Missing: feedback If feedback is requested Status: confirmed The issue was confirmed by others WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

4 participants