Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] PD: Adding guide curves to loft #8754

Open
2 tasks done
69Piero opened this issue Mar 6, 2023 · 2 comments
Open
2 tasks done

[Feature Request] PD: Adding guide curves to loft #8754

69Piero opened this issue Mar 6, 2023 · 2 comments
Labels
Feature FR for improvements or new features WB Part Design Related to the Part Design Workbench

Comments

@69Piero
Copy link

69Piero commented Mar 6, 2023

Is there an existing request for this?

  • I have searched the existing requests

Forums discussion

https://forum.freecad.org/viewtopic.php?t=76467

Subproject(s) affected?

PartDesign

Idea description

Currently the loft between two profiles is straight and out from user's control, so the feature is weak. You need ability to guide the loft by paths (sketches) so the user can manage "the way in which a profile turns into another one."

Sweep could be a solution, but currently it supports just one guide curve so doesn't solve the issue giving back an incorrect model.

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added WB Part Design Related to the Part Design Workbench Feature FR for improvements or new features labels Mar 8, 2023
@SV001R
Copy link

SV001R commented Dec 11, 2023

I need this feature too. Making guided loft solid or surface is weakpoint of FC's loft feature.

@AjinkyaDahale
Copy link
Contributor

So some opinions here:

  1. Since we already have a sweep (also called pipe sometimes in PD source code), it is that method which should have these additional "guides", unless a loft can do something sweep cannot (this maybe possible given that we use different methods for loft and sweep, viz. BRepOffsetAPI_ThruSections and BRepOffsetAPI_MakePipeShell). There may also be a case for combining Loft and Sweep, but let's not go there just yet.
  2. Sweep already has a single guide. There is also an "auxiliary spine", though it is used to define the normal at every cross section. So, to summarize, if we view a sweep as a union of interpolated faces, the "spine" dictates where the "relevant" point at each interpolated cross section (this term might not be the best descriptor) lies, and the "auxiliary spine" dictates how that interpolated cross section should be oriented. The only means we have to control the shape of the interpolated cross section is to add more in-between shapes.
  3. It is theoretically possible to imagine multiple spines dictating the shape of the cross sections. To take it to the extreme, this can also theoretically be done continuously along the whole wire (requiring uncountably infinite spines). but this is not supported in OCCT itself, at least in BRepOffsetAPI_MakePipeShell. There may be other methods, which are used by the curve workbenches that give better control.

Right now I see two options:

  1. Find out those methods from the curve WB's and use them here. OR
  2. Suggest that the user move to these workbenches if the item they want to build is that complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features WB Part Design Related to the Part Design Workbench
Projects
None yet
Development

No branches or pull requests

4 participants