[Issue] Changed xml namespace url affects TechDraw templates

[WandererFan]

Is there an existing issue for this?

• I have searched the existing issues

Forums discussion

https://forum.freecad.org/viewtopic.php?t=77905

Version

0.21 (Development)

Full version info

[code]
OS: Ubuntu Core 20 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.0.33004 (Git) Snap 686
Build type: Release
Branch: master
Hash: 8c382af744f9a5cddd06f9195daa5629dbcf7536
Python 3.8.10, Qt 5.15.7, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/Canada (en_CA)
Installed mods: 
  * A2plus 0.4.60k
[/code]

Subproject(s) affected?

Techdraw

Issue description

Local build and AppImage display OP's custom template correctly, Snap does not. Snap version does display templates from the distribution correctly.

Possibly related to recent changes to Svg handling for Qt6??

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[luzpaz]

Let me know what needs to happen to the configs on the Snap side of things.

[wwmayer]

Possibly related to recent changes to Svg handling for Qt6??

This can be ruled out. As a start point you can use 96bf293

[wwmayer]

The change to blame is PR #9352

[luzpaz]

@wwmayer i made that PR 😵‍💫
What did it break ?

Edit: Another Snap package related issue was just reported in the forum

[wwmayer]

What did it break ?

I don't know. Must be checked first.

EDIT: It's the changes made to DrawUtil.h:
#define FREECAD_SVG_NS_URI "http://www.freecad.org/wiki/index.php?title=Svg_Namespace"

FREECAD_SVG_NS_URI is used for the XML query and because it doesn't match any more it won't find the click handles.

[adrianinsaval]

can it be made to match either freecad or freecadweb variations or do we revert to freecadweb here? If we need to go back to freecadweb it probably needs to be reverted on all built-in templates too

[WandererFan]

Thanks @wwmayer. I was still in mid-bisect.

Notice to custom template users:
https://forum.freecad.org/viewtopic.php?t=77955

[WandererFan]

"can it be made to match either freecad or freecadweb variations or do we revert to freecadweb here?"

Going forward, we can change the code to use either url, but the v0.20 and earlier standard templates will still point to freecadweb and the old code will still look for freecadweb.

As long as the freecadweb url is still valid the old version will still work. Is freecadweb going to be removed any time soon?

[Syres916]

Could the references to Snap please be removed as this applies to all, does it not?

[adrianinsaval]

Keeping the freecadweb domain redirect shouldn't be expensive so I don't think there's any reason to get rid of it

[luzpaz]

Keeping the freecadweb domain redirect shouldn't be expensive so I don't think there's any reason to get rid of it

We have to keep ownership of the freecadweb domain for 2 main reasons: it's an important legacy URL for the project and also has many many years of search engine history (people buy domain names just for that these days because of traffic and high search ranking

[adrianinsaval]

@luzpaz was that a mistake or was this fixed and I missed it?

[luzpaz]

My bad, fat fingers

[wwmayer]

@WandererFan
I guess the ticket can be closed as 1b2857c is supposed to fix it.

[WandererFan]

completed.