3 strange code fragments

[mjunix]

(I don't have any experience with this codebase so maybe these are not bugs.)

1. freecol/src/net/sf/freecol/client/control/InGameController.java

   Line 975 in ef483bd

   } if (unit.isAtLocation(destination)) {

   
   The formatting is strange, the if-statement start on same line as a closing brace, is an else missing before the if? If no else is missing then the if-statement should probably moved to a line of its own.

2. freecol/src/net/sf/freecol/server/ai/ColonyPlan.java

   Lines 1054 to 1060 in ef483bd

   	if (expert != null
   	&& u.getUnitChange(UnitChangeType.EXPERIENCE, expert) != null) {
   	score += 10000;
   	} else if (expert != null
   	&& u.getUnitChange(UnitChangeType.EXPERIENCE, expert) != null) {
   	score -= 10000;
   	}

   
   The two if-statements have the same condition.

3. freecol/src/net/sf/freecol/client/gui/mapviewer/MapViewer.java

   Line 496 in ef483bd

   / ((tcb.getBottomRightDirtyTile().getX()-tcb.getTopLeftDirtyTile().getX()) * (tcb.getBottomRightDirtyTile().getY()-tcb.getBottomRightDirtyTile().getY()));

   
   Identical expressions (tcb.getBottomRightDirtyTile().getY()) on both sides of subtraction operator.

[mpope042]

Correct on all counts I think. #1 is a typo/omission, #2 is a logic error (long time since I wrote that code, glad I put a comment above), and #3 looks like the second getY is on the wrong corner of the box. All three are fixed in commits 56e3d26, 4b418cd, 5c4bafb respectively (note: sourceforge git repository commits, SF is the freecol development master, github merely contains a mirror, please prefer the SF bug tracker for further such issues).