Crash in NSCodec when connecting to Windows 8

[mfleisz]

We are experiencing some problems when using Bitmap V3 Cache with NSCodec on Windows 8. It seems that a bunch of tiles are correctly decoded - then suddenly it crashes in the NSCodec RLE decoding.

Steps to reproduce the problem:

• We used Win8 x64 Professional
• Enable the following policy: Computer Configuration/Administrative Templates/Windows Components/Remote Desktop Services/Remote Desktop Session Host/Remote Session Environment/Enable RemoteFX encoding for RemoteFX clients designed for Windows Server 2008 R2 SP1
• Run xfreerdp using the following command line:
  client/X11/xfreerdp /u:demo1 /p:qw /v:192.168.50.158 /gdi:sw /bpp:32 /codec-cache:nsc
• The client crashes:
  #0 0xb7c74c6a in ?? () from /lib/i386-linux-gnu/libc.so.6
  Initial transport layer implementation #1 0xb7d598d1 in nsc_rle_decode (in=0xb6d373f7 "\377",

 out=0xb6d6211c "\377\...."..., origsz=1024)
 at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/codec/nsc.c:133

#2 0xb7d599a4 in nsc_rle_decompress_data (context=0xb6d1d500)

 at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/codec/nsc.c:164

#3 0xb7d59efb in nsc_process_message (context=0xb6d1d500, bpp=32,

width=64, height=64,
data=0xb6d24428 "\237\n", length=3504)
at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/codec/nsc.c:343
#4 0xb7db8c5f in gdi_Bitmap_Decompress (context=0x8114650,

bitmap=0xb6d5d1e8, data=0xb6d24428 "\237\n",
width=64, height=64, bpp=32, length=3504, compressed=1, codec_id=1)
at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/gdi/graphics.c:121
#5 0xb7d771b4 in update_gdi_cache_bitmap_v3 (context=0x8114650,

cache_bitmap_v3=0x80bf340)
at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/cache/bitmap.c:146
#6 0xb7df2aa2 in update_recv_secondary_order (update=0x80bca80,

s=0x80c3418, flags=3 '\003')
at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/core/orders.c:1970
#7 0xb7df314d in update_recv_order (update=0x80bca80, s=0x80c3418)

 at /home/mfleisz/projects/FreeRDP-mfleisz/libfreerdp/core/orders.c:2122