Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11 fullscreen mode seems to be broken in 12ec6c6 #1361

Closed
arcadoss opened this issue Jul 18, 2013 · 3 comments
Closed

x11 fullscreen mode seems to be broken in 12ec6c6 #1361

arcadoss opened this issue Jul 18, 2013 · 3 comments

Comments

@arcadoss
Copy link

➜ FreeRDP git:(12ec6c6) git bisect bad 12ec6c6
12ec6c6 is the first bad commit
commit 12ec6c6
Author: Marc-André Moreau marcandre.moreau@gmail.com
Date: Sun Apr 28 18:48:27 2013 -0400

xfreerdp: add support for selecting individual monitors

:040000 040000 df5f378eb4ec98094759651efcc62cf774509980 925af87143a3abf917bc939785168c9e277b19ec M client
:040000 040000 9a0c655efc427387b2e46535b401c6044fc9ae61 b03323c7537347fb74cb1b6cd46f37b3ba359658 M include

@bailli
Copy link
Contributor

bailli commented May 16, 2014

It seems this bug depends on the X environment. I have encoutered some cases were fullscreen works and some were it doesn't.

A quick "hack" to get it working (but probably break individial monitors) is to change the following line 147 in xf_window.c (

XMoveResizeWindow(xfi->display, window->handle, settings->DesktopPosX, settings->DesktopPosY, window->width, window->height);
)
settings->DesktopPosX and DesktopPosY seem to hold wrong values, changing these two parameters back to 0 (as before the mentioned commit) full screen works again (for me).

@bmiklautz
Copy link
Member

I think this might also be related to #1695

@bmiklautz bmiklautz removed this from the 1.1 milestone May 25, 2016
@akallabeth akallabeth added this to the 2.0-rc1 milestone Nov 23, 2017
@akallabeth
Copy link
Member

Working on target release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants