Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server side external io api logic broken #6664

Open
sss123next opened this issue Dec 13, 2020 · 3 comments
Open

server side external io api logic broken #6664

sss123next opened this issue Dec 13, 2020 · 3 comments
Labels
help-wanted server
Milestone
next

Comments

@sss123next
Copy link
Contributor

sss123next commented Dec 13, 2020 •
edited
Loading

currently impossible to override io.TransportAttach because ->context->rdp->transport is available only after freerdp_peer_context_new call, but inside of freerdp_peer_context_new transport_attach is called before any chance to override it, it is possible to create own implementation of freerdp_peer_context_new, but it will also add requirement for implementation of lot freerdp internals which is undesired and should be avoided if possible.
@sss123next
Copy link
Contributor Author

sss123next commented Dec 13, 2020 •
edited
Loading

also looks like some in some other places file descriptor used directly in server side (peer) code

@akallabeth akallabeth added this to the next milestone Dec 14, 2020
@sss123next
Copy link
Contributor Author

looks like another task for me (.
ok, i am on it.

@sss123next
Copy link
Contributor Author

#6668 - started work here

@akallabeth akallabeth modified the milestones: 3.0.0-beta1, next-3.0, next Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted server
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@sss123next @akallabeth