Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new way of subscribe using profiles #1615

Closed
cjfloss opened this issue Aug 25, 2021 · 10 comments · Fixed by #4238
Closed

A new way of subscribe using profiles #1615

cjfloss opened this issue Aug 25, 2021 · 10 comments · Fixed by #4238
Assignees
Labels
enhancement New feature or request

Comments

@cjfloss
Copy link
Contributor

cjfloss commented Aug 25, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
I find it a bit counter-intuitive to subscribe using multiple profiles.
My path to subscribe to a channel consists in searching for a channel, clicking on the channel, and hitting "subscribe".
The way FreeTube is right now, leads me to end up not using the multiples profiles, because I have to go to the top-right and change profile, and then clicking subscribe, this breaks the flow of adding a subscription.

Describe the solution you'd like to see implemented
I think a good solution is to have a kind of a dropdown combined with the subscribe button so when the user clicks the 'subscribe' button, he can select multiples profiles which to add the channel.

Describe alternatives you've considered

Screenshots
A quick rough sketch of what it may looks like
A rough sketch

Additional context

@cjfloss cjfloss added the enhancement New feature or request label Aug 25, 2021
@PrestonN PrestonN added this to To assign in Feature Requests Aug 25, 2021
@jasonhenriquez
Copy link
Collaborator

This has been discussed before in #568. I like the mockup, albeit it may have to list full profile names (or at least the first few letters) to disambiguate profiles with the same color / first letter.

@peepo5
Copy link
Contributor

peepo5 commented Sep 16, 2021

there could be a sub-button dropdown for this

@minhhang107
Copy link
Contributor

Hi, I'd like to implement this feature.
I'm planning to do something like this
subscribe

Let me know what you think about this idea

@minhhang107
Copy link
Contributor

@PrestonN I think the subscribe button should be kept separate so I revised the UI and added + button to show/hide the profiles.
Also in the Channel page, we also have the Subscribe button. Do you also want to add this feature to the Channel page as well?

ezgif-3-54ba3e45b419

@PrestonN
Copy link
Member

PrestonN commented Dec 3, 2021

Hi @minhhang107!

Yes, please also make the change to the subscribe button in the channels page. Looks good so far!

@minhhang107
Copy link
Contributor

minhhang107 commented Dec 3, 2021

@PrestonN Do you think it's better to create a component for the subscription or just directly add to the current code?

@peepo5
Copy link
Contributor

peepo5 commented Dec 4, 2021

looks good.

@drod3763
Copy link

drod3763 commented Jan 6, 2022

I like this idea as the way Profiles work right now is too clunky, especially if you have a lot of subscriptions. Maybe the UI should also show any existing profiles the channel is attached to. I envision something like the profile icon being next to the name or something like that.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
7 participants