Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: DeArrow support #3696

Closed
3 tasks done
Terkyz opened this issue Jun 23, 2023 · 10 comments · Fixed by #3688
Closed
3 tasks done

[Feature Request]: DeArrow support #3696

Terkyz opened this issue Jun 23, 2023 · 10 comments · Fixed by #3688

Comments

@Terkyz
Copy link

Terkyz commented Jun 23, 2023

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Sponsorblock developers created a new tool or browser extension called DeArrow to filter out misleading content and clickbait thumbnails, it would be great if this tool was integrated into Freetube.

Proposed Solution

That this tool if possible be integrated into Freetube in the style of Sponsorblock.

Alternatives Considered

Not integrated, after all, nobody loses anything, or simply limit myself to using it from my browser.

Issue Labels

new feature, support for external software

Additional Information

Titles can be any arbitrary text. Thumbnails are screenshots from specific timestamps in the video. These are user submitted and voted on. By default, if there are no submissions, it will format the original title to the user-specified format, and set a screenshot from a random timestamp as the thumbnail. This can be configured in the options to disable formatting, or show the original thumbnail by default.

If it is possible to integrate this capability within FreeTube so that the user can also support the development of DeArrow and add more videos to the list of submissions.

@Terkyz Terkyz added the enhancement New feature or request label Jun 23, 2023
@FreeTubeBot FreeTubeBot added this to To assign in Feature Requests Jun 23, 2023
@Victor239
Copy link

I'd like to propose an alternative: copy Clickbait Remover for YouTube's functionality.

"This extension replaces thumbnails with a frame from the video, effectively removing any clickbait while still showing a high quality thumbnail so you can still get a good idea of what the video is about. It can also modify titles to stop partial or all caps titles."

@duplexsystem
Copy link

This has not been completed. Thumbnails are still not implemented, nor is the cleaning up of titles without presubmitted replacements (such as caps to no caps, etc).

@lothar-cell
Copy link

Development is completed, it will come out with the next update.

@aleksejrs
Copy link

aleksejrs commented Jul 6, 2023

I'd like to propose an alternative: copy Clickbait Remover for YouTube's functionality.

@Victor239, the thumbnail part of that was already implemented in General Settings (before v0.18.0-nightly-3064 Beta).

I proposed #3625 for the more complex videos.

@aleksejrs
Copy link

aleksejrs commented Jul 6, 2023

@lothar-cell

Development is completed, it will come out with the next update.

#3688 only implements titles.
The thumbnail functionality needs more settings affecting privacy (actually, titles could also use some).

Submission seems to give you a public user account with the extension's defaults, but apparently if you remove the userID, it will use a random one every time.

@Hanif-F
Copy link

Hanif-F commented Oct 24, 2023

I compare the DeArrow from Freetube and the DeArrow from browser extension, and found that some video titles that are changed with the extension still shows the original in Freetube.

@efb4f5ff-1298-471a-8973-3d47447115dc

Hi @Hanif-F could u maybe send some screenshots?

@Hanif-F
Copy link

Hanif-F commented Oct 25, 2023

Browser:
image

Freetube:
image

There are only two titles that got changed in those videos, there are more changed titles below, though.

@ajayyy
Copy link
Contributor

ajayyy commented Oct 25, 2023

I think the problem is here

if (Array.isArray(data?.titles) && data.titles.length > 0 && (data.titles[0].locked || data.titles[0].votes > 0)) {
cacheData.title = data.titles[0].title
}

Should be data.titles[0].votes >= 0

@efb4f5ff-1298-471a-8973-3d47447115dc

@ajayyy is it maybe possible for u to create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants