Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Quick Settings Menu #4412

Open
3 tasks done
kommunarr opened this issue Dec 2, 2023 · 3 comments
Open
3 tasks done

[Feature Request]: Quick Settings Menu #4412

kommunarr opened this issue Dec 2, 2023 · 3 comments

Comments

@kommunarr
Copy link
Collaborator

kommunarr commented Dec 2, 2023

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

There are certain settings that are tinkered with more regularly, like the current Invidious instance, region for trending, proxy settings, and base theme. Changing routes just to change these can be quite an onerous journey, though. And even if we do ever have t*bs, that change-settings flow is still its own journey that you have to go out of your way to embark upon.

Proposed Solution

Implement a quick settings menu for changing the most used settings. What those settings should be by default will always be up for debate & will vary based on the UX of this specific implementation. In the interest of getting things out, customization of the displayed settings are out of the scope for this issue. Also, in the interest of starting the discussion, here are my opinions on what those default quick settings should include:

  • Preferred API Backend
  • Current Invidious Instance
  • Region for Trending
  • Proxy settings
  • Base Theme
  • (Contingent on available space) Primary & Secondary Color Themes

This does introduce a new question of whether the user should be prompted to enter their chosen password every single time that they open the quick settings. I think you can make a convincing answer for both, depending on which settings are included. Our options are:

  1. Don't put a lock on these because they're less important - no permanent data deletion or overwrite (at the cost of allowing anyone to change these)
  2. Do put a lock on these because they may be considered important (at the cost of it being more tedious to use)
  3. Put an option to put a lock on these (at the cost of growing our ever-expanding Settings)

I would personally be fine with 1 or 3 (with lock disabled by default).

As for the UX of the control itself, it would make sense for it to be a "More Options" button near the Profile Selector icon that opens either a dropdown-ish item and/or a modal dialog box ("and/or" if it becomes a modal dialog box on smaller device sizes).

Alternatives Considered

Don't implement this feature.

Issue Labels

ease of use improvement, improvement to existing feature

Additional Information

For context, here's YT's take on it:
Screenshot_20231201_192448

@kommunarr kommunarr added the enhancement New feature or request label Dec 2, 2023
@FreeTubeBot FreeTubeBot added this to To assign in Feature Requests Dec 2, 2023
@kommunarr kommunarr changed the title [Feature Request]: Quick Settings [Feature Request]: Quick Settings Menu Dec 2, 2023
@efb4f5ff-1298-471a-8973-3d47447115dc

Should we close #1077 in favor of this?

@kommunarr
Copy link
Collaborator Author

kommunarr commented Dec 2, 2023

I think it's a sufficiently different ask (handful of quick settings v.s. making the entire settings page a dialog), but it is worth discussing what our long-term plans for settings should be. If we did have #1077 implemented, this issue would basically become "Implement a pinned settings section". While we don't have #1077 implemented and/or if decide against implementing it (e.g., in favor of a Settings tab), this story is more in line with a quick settings menu like YT.

@absidue
Copy link
Member

absidue commented Dec 2, 2023

Just leaving a note here to say that we shouldn't be comparing it to YouTube, as that menu on YouTube contains the only settings you can change without an account. So it's not really a quick settings menu for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants