Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt brings up context menu #984

Closed
darknuju opened this issue Jan 24, 2021 · 6 comments
Closed

Alt brings up context menu #984

darknuju opened this issue Jan 24, 2021 · 6 comments
Labels
E: keyboard shortcut enhancement New feature or request good first issue Good for newcomers

Comments

@darknuju
Copy link

Behavior of the program
When pressing alt, a context menu pops up at the top of the window.

Expected behavior
This is not exactly unexpected behavior, but I use a tiling window manager and thus regularly use the alt key for various things. It is quite annoying to have the context menu popping in and out and it would be nice to be able to disable that.

To Reproduce
Simply press alt on any part of the program.

Environment Information (please complete the following information):

  • OS: Arch
  • FreeTube version: 0.11.2 beta
  • Installation Method (If applicable): I installed using an aur package
  • Primary API Used: invidious

screenshot

@darknuju darknuju added the bug Something isn't working label Jan 24, 2021
@saideepesh000
Copy link
Contributor

[windows user here] Hey @Wesley-AS, I think this is the behaviour off the OS side, because in every desktop app we see, pressing alt opens/focus up the file menu of its corresponding app,

@GilgusMaximus
Copy link
Contributor

This is something that has to stay, although not on that key in particular. I'm not sure whether this can actually be mapped to another shortcut because that simply comes from Electron.

@darknuju
Copy link
Author

If this isn't fixable, then I guess I will have to live with it. Thank you for your time. Should I close the issue now?

@GilgusMaximus
Copy link
Contributor

No all good. We'll leave it open for now and if someone wants to check that out in Electron itself this is a good issue to tackle for newcomers or at latest if we do the hotkey remapping

@GilgusMaximus GilgusMaximus added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Mar 18, 2021
@GilgusMaximus GilgusMaximus added this to To Assign in Feature Requests Mar 19, 2021
@GilgusMaximus GilgusMaximus moved this from To Assign to Good For New Contributors in Feature Requests Mar 19, 2021
@PrestonN PrestonN moved this from Good For New Contributors to To assign in Feature Requests Sep 27, 2021
@PrestonN PrestonN removed this from To assign in Feature Requests Jan 8, 2022
@PrestonN PrestonN added this to To assign in Feature Requests Jan 8, 2022
@PrestonN PrestonN removed this from To assign in Feature Requests Jan 8, 2022
@theforbiddenpool
Copy link
Contributor

I spend a bit investigating this issue, and it seems to have been fixed on electron with electron/electron#29328, which was then released on version 13.1.0. FreeTube currently uses electron 21.

I tested it myself, and the Alt menu is only displayed after I release the Alt key. Meaning, the Alt key + another key should not trigger the menu. For context, I'm using Arch Linux.
I also tested when the menu was already open, and the Alt key does trigger the menu closing, but I'm still able to do the shortcut. Since it's unlikely somebody will have the Alt menu open anyway, I don't think this is much of a problem.

With this, I would suggest this issue to be closed, as it seems to have been fixed.

@github-actions
Copy link
Contributor

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: keyboard shortcut enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants