-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option fs_accounts
, which is very large, has the autoload flag set to true
#519
Comments
Probably duplicate of #400 |
Yep, as @lkraav mentioned this is a dup of #400 We are aware of the issue and will eventually address it (unfortunately, due to other priorities there's no ETA). @banago I'm not sure how you can have two options with the same |
Hello, I am not a developer but use plugins that use this Freemius SDK. What I do know is that setting wp_options entries to autoload when unnecessary is not just bad coding, it is just plain lazy. I imagine it is not very high up the priority list to fix as most users either do not understand what autoloads on the wp_options table are or do, or have no idea they affect website performance. Honestly, @daigo75 points out quite clearly that a fix is like two minutes work, so why not fix!? I see the even old thread #400 has not been addressed either. I for one am likely to avoid WP plugins that use Freemius in future as it just seems like bloatware to me. |
@skullo27 I wish it was as easy as setting the autoload to |
@vovafeldman Perhaps it could make sense to store the settings used at every page load separately from the ones used less frequently? |
That's the plan, @daigo75. To do so requires a full audit of the settings and making sure we don't break backward compatibility, it's a meaningful infrastructural change. We'll get there eventually. |
@vovafeldman 1,5 years later now - Update? Autoload 250kb in my case and that's really not what supports sustainable wp dev. Thanks for your understanding. Possibility: The plugin "Admin Menu Editor Pro" does apply compression to it's autoload value (optional; can be activated in settings). |
@samuelbauer-io we are working on releasing a solution for it soon. You can follow the updates here #400 |
馃悶 bug report
Behavior:
A client reported that option
fs_accounts
has theautoload
property set toyes
. Apparently, that option is also large in size, so this automatic loading affects the performance significantly.The autoload flag seems to be set by method
FS_Option_Manager::store()
, which uses propertyFS_Option_Manager::$autoload
. Based on a quick inspection, that property is always set tonull
, which means that it defaults to true when functionupdate_option()
is called.The fix could be as simple as setting the
autoload
property tofalse
. That should prevent WordPress from unnecessarily loading the option.Versions: (*)
Freemius SDK Version:
2.4.2WordPress Version:
5.7.xPHP Version:
7.2-7.4Plugin / Theme: (*)
Name:
Aelia Currency Switcher for WooCoommerceSlug:
woocommerce-aelia-currencyswitcherFreemius ID:
6708Note: this affects any plugin, or theme, using the WordPress SDK.
The text was updated successfully, but these errors were encountered: