PHP 8.2 Creation of dynamic propert warnings

[ipajen]

🐞 bug report

Behavior:

• What is the issue? (*)
  SDK generates warnings when using PHP 8.2. Using two different plugins that use the Freemius SDK and both has the same issue.

Versions: (*)

• Freemius SDK Version: 2.5.5
• WordPress Version: 6.2-RC3
• PHP Version: 8.2.0

Creation of dynamic property FS_Site::$charset is deprecated
Creation of dynamic property FS_User::$is_beta is deprecated

[vovafeldman]

Hey @ipajen 👋 thanks for reporting the issue 🐞

Both params no longer exist (or are in use). So, most likely, the site was running an older SDK version before, and the objects were stored in the options table with the properties. Now with the new SDK, unserialize() creates those properties on the fly when the objects are loaded using core's get_option().

We've already started working on the storage layer and will be transitioning from PHP serialization to JSON-based one. We'll resolve it as part of that upgrade.

[ipajen]

@vovafeldman any ETA when it will be released? 🙏

[ipajen]

@vovafeldman Any update on this issue? Thank you!