Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox warns about OpenCollective embed #2480

Open
andretchen0 opened this issue Aug 9, 2023 · 2 comments
Open

Firefox warns about OpenCollective embed #2480

andretchen0 opened this issue Aug 9, 2023 · 2 comments
Labels
coding This issue requires some programming

Comments

@andretchen0
Copy link
Contributor

andretchen0 commented Aug 9, 2023

Since this merge, Firefox warns:

Partitioned cookie or storage access was provided to “https://opencollective.com/ancientbeast/tiers/sponsor.svg?avatarHeight=61&width=800&limit=10” because it is loaded in the third-party context and dynamic state partitioning is enabled.

... which reads awfully scary.

It's due to how the SVG is embedded. It's done as an <object>. You can load third-party SVGS as <img />.

CSS will need to be adjusted as it depends on #opencollective_banner > object.

It would be best to include the OpenCollective SVG data in the local assets. That allows it to be packed. And it avoids the SVG becoming a third-party "tracking pixel" for players – and devs!

To Reproduce

  1. Start a game in Firefox.
  2. Open console.
  3. See warning.

Expected behavior

No warning. No third-party tracking.

@DreadKnight DreadKnight added the coding This issue requires some programming label Aug 10, 2023
@DreadKnight DreadKnight added this to the 0.6 - Cyber Wolf milestone Aug 10, 2023
@JoelFernandes09
Copy link
Contributor

Can I take this one if it hasn't been started yet?

@DreadKnight
Copy link
Member

@JoelFernandes09 Heya! Poke at some other issue for now please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding This issue requires some programming
Projects
None yet
Development

No branches or pull requests

3 participants