Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11/10 bug: layout okay, but actual elements have no set widths #32

Closed
fregante opened this issue Aug 3, 2015 · 7 comments
Closed

Comments

@fregante
Copy link

fregante commented Aug 3, 2015

screen shot 2015-08-03 at 01 45 50

I'll try just using IE's own Grid implementation instead of relying on the polyfill (even simply for performance reasons), but I thought I'd tell you about this issue anyway.

@FremyCompany
Copy link
Owner

Thanks, I'll have a look at it. What are the normally-used-css min/max/width+height of the child elements, and what are your grid columns/rows sizes?

// FWIW I would recommend using the IE's native implementation 
// whenever possible, too.

@fregante
Copy link
Author

fregante commented Aug 3, 2015

The content has no pre-set size, they usually just fill the container

@fregante
Copy link
Author

I ended up removing this polyfill again, now I'm using… tables… plus a custom script to move the elements around at breakpoints. I'm basically leaving the layout to the browser, it's more performant and less buggy in all situations.

@FremyCompany
Copy link
Owner

This is already part of the current readme:

Should I use that in production?

Your call. I wouldn’t say this polyfill is slow by any measure, but your mileage may vary on mobile devices. My advice would be to use the polyfill only on tablets and desktops at the moment, after you have tested the compatibility and performance extensively on a representative number of devices.

@fregante
Copy link
Author

My bad! I had actually edited the comment because I saw that. And really I noticed that the issue was unrelated to the polyfill at all. It was an overlay with a scrollable area that was still activated even with visibility:hidden, it looked like the site wouldn't respond to the first scroll.

@FremyCompany
Copy link
Owner

Glad to see this wasn't an issue related to the polyfill. That being said, I would argue using a custom script may be a better idea at the moment anyway ;-) Given you update the website in real time, could you make a snapshot of it as a static html and send it to me by email so I can debug the IE issue at a later time? You can find my email on my website (my-github-username dot com).

@Hypnosphi
Copy link

I have an example where childrens explicit widths are ignored: http://codepen.io/anon/pen/bBQbNq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants