Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing-port-categories.sh should be run in between commit processing #101

Open
dlangille opened this issue Nov 3, 2018 · 3 comments
Open

Comments

@dlangille
Copy link
Contributor

dlangille commented Nov 3, 2018

Sometimes the missing-port-categories.sh script gives false positives. This can occur if the script is run while a commit is being processed.

We would run that via fp-daemon.sh (now freshports) which checks for ${FLAGDIR}/job_waiting and then invokes job-waiting.pl

job-waiting.pl would then invoke missing-port-categories.sh

At present, hourly/240.fp_missing_port_categories invokes missing-port-categories.sh directly. Instead, it would:

touch $FreshPorts::Config::check_missing_port_categories # Needs to defined
touch ${FLAGDIR}/job_waiting

This is the false positive:

This is a list of ports that do not have entries in the ports_categories table
This can be fixed with this query:

begin;  insert into ports_categories select id, category_id from ports_active PA WHERE NOT EXISTS (SELECT * from ports_categories PC where PC.port_id = PA.id and PC.category_id = PA.category_id);

This is a list of the ports in question:

 id   | category_id |            name            |  category  |                port                
-------+-------------+----------------------------+------------+------------------------------------
50670 |          25 | gstreamer1-plugins-openmpt | audio      | audio/gstreamer1-plugins-openmpt
50669 |           4 | gstreamer1-plugins-vulkan  | graphics   | graphics/gstreamer1-plugins-vulkan
50671 |          52 | gstreamer1-plugins-aom     | multimedia | multimedia/gstreamer1-plugins-aom
(3 rows)
@dlangille
Copy link
Contributor Author

@dlangille
Copy link
Contributor Author

I'm creating:

  • freshports/periodics
  • scripts/helper_scripts/set_hourly_flags.sh

@dlangille
Copy link
Contributor Author

This is now running at dev-ingress01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant