Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity tests - cache and paging #451

Closed
dlangille opened this issue Aug 6, 2023 · 4 comments
Closed

sanity tests - cache and paging #451

dlangille opened this issue Aug 6, 2023 · 4 comments

Comments

@dlangille
Copy link
Contributor

There is no paging on https://www.freshports.org/sanity_test_failures.php

The cache does not seem to be automatically cleared:

  • commit delete
  • new sanity test failure
@dlangille
Copy link
Contributor Author

This was fixed by amending the existing CommitsCacheClear() function in fp-listen.py

Every time a commit is amended/deleted, this function will clear the following from cache:

existing:

COMMIT_CACHE_PATH      = %(BASEDIR)s/cache/commits/%%s/

new:

SANITY_CACHE_PATH      = %(BASEDIR)s/cache/general/sanity_test_failures.%%s.*.html
SANITY_MAIN_CACHE_PATH = %(BASEDIR)s/cache/general/sanity_test_failures.PageSize*.html

Where %%s is the commit id.

@dlangille
Copy link
Contributor Author

This does mean that the sanity test list is cleared each time a commit occurs. That is overkill. However, going the other way creates more work and more code. Simple cache clearing is better cache clearing.

@dlangille
Copy link
Contributor Author

Fixed with release 1.0.7 - that code is not on github.

@dlangille
Copy link
Contributor Author

Installed in prod by jesse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant