Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sites with non-absolute paths to favicons don't load #5838

Closed
jaden opened this issue Nov 9, 2023 · 0 comments · Fixed by #5839
Closed

[BUG] Sites with non-absolute paths to favicons don't load #5838

jaden opened this issue Nov 9, 2023 · 0 comments · Fixed by #5839
Milestone

Comments

@jaden
Copy link
Contributor

jaden commented Nov 9, 2023

Describe the bug

Sites that have favicon link href's using a relative or absolute path without a domain don't load.

Examples:

To Reproduce
Steps to reproduce the behavior:

  1. Subscribe to one of the above sites
  2. Instead of showing the site's favicon on feed items, it shows the generic one.

Expected behavior
The favicon referenced on the site should be shown.

Environment information (please complete the following information):

  • Device: Any
  • OS: Any
  • Browser: Any
  • FreshRSS version: 1.22.1
  • Database version: SQLite
  • PHP version: PHP 8.2
  • Installation type: Manual

Additional context
I've been testing a fix that has worked on all of the sites I've tested it with. I'll submit a PR.

@Alkarex Alkarex added this to the 1.23.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants