This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
Add Support for more Garage door operators and modernize code #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'typing.List' is deprecated, use 'list' instead pylint(deprecated-typing-alias)
In binary_sensor.py the import of "const" was with an improper path.
There are garage operators, that have a position attribute which is not editable. In that case, they show position, but can not be operated by set_position. Also tackle some deprecation notices.
Adding all Impulse type switching attributes from pymee, to discover more switches on devices. Naming changed, so that special impulses always get named by their type.. tackled some deprecation messages.
If a sensor neither has a name nor a device class, name it after it's AttributeType string
|
Closes #26 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main lint points I've addressed:
It is a larger pull request this time, but it should bring the code to a stand where it is set up for the future.
Hope you can spare the time to check.