Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwork of mandatory elements #39

Closed
jlnrrg opened this issue Apr 19, 2021 · 1 comment · Fixed by #43
Closed

Overwork of mandatory elements #39

jlnrrg opened this issue Apr 19, 2021 · 1 comment · Fixed by #43
Labels
bug report feature request Request to add new functionality

Comments

@jlnrrg
Copy link

jlnrrg commented Apr 19, 2021

Right now these parameters are mandatory in BottomBarWithSheet:

  • bottomBarTheme
  • sheetChild
  • onSelectItem
    and also the MainActionButtonTheme requires an icon.

From my point of view the MainActionButtonTheme (and MainActionButton) should orientate more on the FloatingActionButton which has no required field. If there is no icon provided this does not matter, as the FAB is there but just without an icon.
Also the bottomBarTheme must not be required as the package should provide default settings based on the Theme.of(context) values or internal default values.

@Frezyx
Copy link
Owner

Frezyx commented Apr 25, 2021

I completely agree with you !
I realized this very late and now I'm trying to figure out how to fix it as imperceptibly as possible.

@Frezyx Frezyx added bug report feature request Request to add new functionality labels Apr 25, 2021
@Frezyx Frezyx linked a pull request Apr 25, 2021 that will close this issue
@Frezyx Frezyx closed this as completed Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report feature request Request to add new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants