Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 horizontal form issues #297

Open
1 of 3 tasks
burzum opened this issue Jan 13, 2020 · 0 comments
Open
1 of 3 tasks

1.4 horizontal form issues #297

burzum opened this issue Jan 13, 2020 · 0 comments
Labels

Comments

@burzum
Copy link

burzum commented Jan 13, 2020

This is a (multiple allowed):

  • bug

  • enhancement

  • feature-discussion (RFC)

  • BootstrapUI Version: 1.4

What you did

Updated from 0.3 to 1.4.

image
image

Expected Behavior

That the horizontal form text inputs display as before.

image
image

See the Bootstrap docs as well https://getbootstrap.com/docs/3.4/css/#forms-inline

<form class="form-inline">
  <div class="form-group">
    <label for="exampleInputName2">Name</label>
    <input type="text" class="form-control" id="exampleInputName2" placeholder="Jane Doe">
  </div>
  <div class="form-group">
    <label for="exampleInputEmail2">Email</label>
    <input type="email" class="form-control" id="exampleInputEmail2" placeholder="jane.doe@example.com">
  </div>
  <button type="submit" class="btn btn-default">Send invitation</button>
</form>

Actual Behavior

They're missing the div container. Also something is wrong with the labels, I've just noticed this.

The cause of the problem is this commit. When I revert it everything is fine:

2b5a229#diff-86d5537968f770710b98fddb2840fcda

burzum referenced this issue Jan 13, 2020
Adding simple test case to make sure class key exists in checkClasses method

checkClasses uses the entire $options array and not just only the 'class' part
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants