Add custom gitlab URL

[alebec]

Hello,

Is it possible to add an option for a custom gitlab domain (with gitlab CE) ?

I can add it in src/Controllers/GitLabAuthController.php but i don't know how to make it configurable.

return new Gitlab([
            'clientId'        => $this->settings->get('fof-auth-gitlab.client_id'),
            'clientSecret' => $this->settings->get('fof-auth-gitlab.client_secret'),
            'redirectUri'  => $redirectUri,
            'domain'       => 'https://mygitlab.myhost.com',
        ]);

[Ralkage]

Hi @alebec, I am looking to add this as an option in an upcoming release but first I am going to have to test it on my end :)

I'll keep you updated and ask for feedback if needed.

[Braintelligence]

Just (enhance+)merge #9

[Ralkage]

#9 didn't include the production JS build changes so I'll have to fix that and possibly revert to using the non-fof-component way of adding a settings modal because I'm currently having issues with the @fof/components package 🙈

[Ralkage]

@Braintelligence fixed the issue with using the latest @fof/components package, some changes were made in that package and I finally figured out what I needed to change/add to get things working again 😄

I'm gonna attempt to work on your suggestions (I need to test both), but I eventually will announce that as of beta 14, this extension will no longer be updated and will be superseded by fof/oauth. I will make a more formal announcement on Flarum Discuss once I tag a new release 👀

[Braintelligence]

Does fof/oauth already support self-hosted Gitlab? The readme is super-short...

[Ralkage]

Does fof/oauth already support self-hosted Gitlab? The readme is super-short...

It does not, in its current state anyways. But rest assured I already have an feature enhancement on the works to keep as a reminder to add this optional feature :)

For now, I’m gonna close this issue, feel free to chime in on that discussion going on in that issue I just linked ;)