Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Only show the Log In Button icons (alternative layout)" option does not work on Google button #24

Closed
rafaucau opened this issue Apr 14, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@rafaucau
Copy link

Bug Report

Current Behavior
The "Only show the Log In Button icons (alternative layout)" option does not work on the Google button. It looks very bad.

Steps to Reproduce

  1. Enable "Only show the Log In Button icons (alternative layout)"
  2. Enable sign in with Google

Expected Behavior
The Google login button should look like the rest of the buttons.

Screenshots
image
image

@rafaucau rafaucau added the bug Something isn't working label Apr 14, 2021
@clarkwinkelmann
Copy link
Member

That's expected behavior. That's the only design allowed by Google's branding guidelines.

https://developers.google.com/identity/branding-guidelines

We didn't want to remove the alternative layout just because you have Google enabled, but it's true that it most likely won't work well together.

@rafaucau
Copy link
Author

@clarkwinkelmann
If not following Google's guidelines is illegal then it can still be done better.
E.g. Google button can be moved to the end of the list, centered on a new line

@clarkwinkelmann
Copy link
Member

Actually, it was the last item and it might have been centered. But since then we added the LinkedIn button at the end 😅

We could move Google back to the end indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants