NotificationMailer constructor parameters changed in Flarum 1.5, override broken

[clarkwinkelmann]

SettingsRepositoryInterface $settings was added as a third constructor parameter to NotificationMailer in Flarum 1.5.

https://github.com/flarum/framework/blob/v1.5.0/framework/core/src/Notification/NotificationMailer.php#L40

public function __construct(Mailer $mailer, TranslatorInterface $translator, SettingsRepositoryInterface $settings)

It throws an error because we are not providing the correct number of parameters in our extended class:

pretty-mail/src/Overrides/NotificationMailer.php

Lines 50 to 59 in 43c8c21

	public function __construct(Mailer $mailer, View $view, SettingsRepositoryInterface $settings, TranslatorInterface $translator, UrlGenerator $url, Paths $paths)
	{
	parent::__construct($mailer, $translator);
	$this->view = $view;
	$this->settings = $settings;
	$this->url = $url;
	$this->assets_dir = $paths->public.DIRECTORY_SEPARATOR.'assets'.DIRECTORY_SEPARATOR;
	}

Change made in flarum/framework#3525

[betalk-ir]

Hi, Any progress to fix?
I just waiting for this extension to upgrade to 1.5!
My forum just send alot mails to users and don't want to send email without our custom template.

[clarkwinkelmann]

Fixed in version 1.1.1