Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image proxy 403, viewDiscussions is now viewForum #16

Closed
clarkwinkelmann opened this issue Jul 18, 2021 · 1 comment · Fixed by #19
Closed

image proxy 403, viewDiscussions is now viewForum #16

clarkwinkelmann opened this issue Jul 18, 2021 · 1 comment · Fixed by #19
Assignees
@imorland
Labels
bug Something isn't working

Comments

@clarkwinkelmann
Copy link
Member

Bug Report

Current Behavior
Non-admins can't use the image proxy.

Screenshots
image

Possible solution(s)
We use viewDiscussions permission which as renamed to viewForum in Flarum.

secure-https/src/Api/Controllers/GetImageUrlController.php

Line 44 in 0358295

$actor->assertCan('viewDiscussions');

Additional Context
Report https://discuss.flarum.org/d/17771-friendsofflarum-secure-https/29
@clarkwinkelmann clarkwinkelmann added the bug Something isn't working label Jul 18, 2021
@fdelapena
Copy link

The proposed patch works for me, thanks!

@imorland imorland self-assigned this Jul 1, 2022
@imorland imorland mentioned this issue Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imorland imorland

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use correct permission for proxy FriendsOfFlarum/secure-https
3 participants
@fdelapena @clarkwinkelmann @imorland