New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Symfony ruleset #5426
Merged
Merged
Update Symfony ruleset #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
commented
Jan 13, 2021
src/RuleSet/Sets/SymfonyRiskySet.php
Outdated
'scope' => 'namespaced', | ||
'strict' => true, | ||
], | ||
'native_constant_invocation' => true, // todo: extend integration test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keradus
force-pushed
the
2.17_update_sf_rules
branch
2 times, most recently
from
January 18, 2021 02:31
50749e3
to
50e0404
Compare
keradus
force-pushed
the
2.17_update_sf_rules
branch
from
January 18, 2021 02:35
c680bee
to
3161ebf
Compare
weaverryan
added a commit
to symfony/maker-bundle
that referenced
this pull request
Jan 19, 2021
This PR was merged into the 1.0-dev branch. Discussion ---------- [CI] fix php-cs-fixer squawks in CI PHP-CS-Fixer/PHP-CS-Fixer#5426 updated the Symfony ruleset which broke CI. Changes included in this PR are as a result of `php-cs-fixer fix` Commits ------- f236580 php-cs-fixer it up
partikus
added a commit
to ovos/PHP-DI
that referenced
this pull request
Jan 20, 2021
This was referenced Mar 11, 2021
Closed
Closed
This was referenced Mar 11, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.