Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch_case_semicolon_to_colon should skip match/default statements #5447

Merged
merged 1 commit into from Jan 19, 2021
Merged

switch_case_semicolon_to_colon should skip match/default statements #5447

merged 1 commit into from Jan 19, 2021

Conversation

derrabus
Copy link
Contributor

Fixes #5446.

@derrabus derrabus mentioned this pull request Jan 18, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 91.928% when pulling c4c8869 on derrabus:bugfix/switch-match-default into 51f38fe on FriendsOfPHP:2.17.

keradus
keradus approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, @derrabus

@keradus keradus added this to the 2.17.5 milestone Jan 19, 2021
@keradus
Copy link
Member

keradus commented Jan 19, 2021

Thank you @derrabus.

@keradus keradus merged commit 898719e into PHP-CS-Fixer:2.17 Jan 19, 2021
@derrabus derrabus deleted the bugfix/switch-match-default branch January 19, 2021 10:31
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 11, 2021
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.5
Development

Successfully merging this pull request may close these issues.

switch_case_semicolon_to_colon fixer breaks match expressions
3 participants
@derrabus @coveralls @keradus