SingleSpaceAfterConstructFixer - better handling of closing parenthesis and brace #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jan 22, 2021
| '<?php | ||
| new Dummy(/* a */); | ||
| new Dummy(/** b */); | ||
| foo(/* c */); |
There was a problem hiding this comment.
what about foo('x'/* c */, 'y'); ?
I think it still enforces space after */ which is againt every convention
There was a problem hiding this comment.
also for block comment before ->, see https://github.com/atk4/data/pull/827/files#diff-1b13a61af17b481a4e15159a87f2a89937836e504284460f2164bfafc1d32348R83
This was referenced Mar 11, 2021
Closed
Closed
Closed
This was referenced Mar 11, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5448