Fix runtime check of PHP version #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
added a commit
to mvorisek/PHP-CS-Fixer
that referenced
this pull request
Jan 27, 2021
hason
reviewed
Jan 27, 2021
| } elseif (!defined('PHP_VERSION_ID') || \PHP_VERSION_ID < 50600 || \PHP_VERSION_ID >= 80100) { | ||
| } elseif ( | ||
| !defined('PHP_VERSION_ID') | ||
| || \PHP_VERSION_ID === 80000 |
There was a problem hiding this comment.
This is a bug. Version 8.0.* is supported.
There was a problem hiding this comment.
@hason , no.
8.0.0 is not supported due to description from few lines below.
8.0.1+ is supported
This was referenced Mar 11, 2021
Closed
Closed
Closed
This was referenced Mar 11, 2021
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5465