Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoctrineAnnotationBracesFixer false positive #5606

Merged
merged 1 commit into from Apr 11, 2021
Merged

DoctrineAnnotationBracesFixer false positive #5606

merged 1 commit into from Apr 11, 2021

Conversation

Leprechaunz
Copy link
Contributor

Fixes #5120

kubawerlos
kubawerlos approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are correct.

Personally I'm ±0 for that change.

@coveralls
Copy link

coveralls commented Apr 7, 2021 •
edited

Coverage Status

Coverage remained the same at 91.848% when pulling 4196dee on Leprechaunz:doctrine-annotation-braces-psalm into cbde9be on FriendsOfPHP:2.18.

@keradus keradus added this to the 2.18.6 milestone Apr 9, 2021
@kubawerlos kubawerlos added kind/bug RTM Ready To Merge labels Apr 9, 2021
@keradus keradus removed the RTM Ready To Merge label Apr 11, 2021
@keradus keradus force-pushed the doctrine-annotation-braces-psalm branch from 3c46137 to 4196dee Compare April 11, 2021 12:49
@keradus
Copy link
Member

keradus commented Apr 11, 2021

Thank you @Leprechaunz.

@keradus keradus merged commit 6e7e115 into PHP-CS-Fixer:2.18 Apr 11, 2021
@Leprechaunz Leprechaunz deleted the doctrine-annotation-braces-psalm branch April 12, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.18.6
Development

Successfully merging this pull request may close these issues.

DoctrineAnnotationBracesFixer false positive
4 participants
@Leprechaunz @coveralls @keradus @kubawerlos