YodaStyleFixer - fix for assignment operators

[kubawerlos]

Reference: https://github.com/drush-ops/drush/blob/10.4.3/src/internal-forks/Config/Yaml/Unescaper.php#L130

[julienfalque]

Is this correct? < and > have a greater precedence than +=.

[kubawerlos]

Good point 😄

Yet, the problem exists as the referenced code breaks PHP syntax.

[julienfalque]

Not sure what you mean. The referenced code and the code in your tests in valid syntax-wise. Some code may be broken logically, but is it related to PHP CS Fixer?

[kubawerlos]

@julienfalque when you try to fix:

if (0x80 > $c %= 0x200000) {
    return chr($c);
}

with

'yoda_style' => [
    'equal' => false,
    'identical' => false,
    'less_and_greater' => false,
],

there is a syntax error.

[coveralls]

Coverage increased (+0.002%) to 91.561% when pulling ac14f61 on kubawerlos:fix_YodaStyleFixer into 5ad0853 on FriendsOfPHP:2.19.

[keradus]

@kubawerlos can you rebase to solve conflict, pls?

[keradus]

Thank you @kubawerlos.