TypesSpacesFixer - Introduction

[kubawerlos]

closes #5495

[coveralls]

Coverage increased (+0.02%) to 92.339% when pulling eec2de4 on kubawerlos:add_UnionTypesSpacesFixer into cbe00f0 on FriendsOfPHP:master.

[nicolas-grekas]

About the name, should we anticipate for intersection types?
TypesSpacesFixer maybe?
(just asking myself, I'm good with UnionTypesSpacesFixer)

[julienfalque]

@nicolas-grekas Good point! I think we can be fairly sure intersection types will land in PHP at some point. TypesSpacesFixer looks more suitable to me 👍

[kubawerlos]

Wouldn't TypesSpacesFixer suggest handling all spaces in types like function foo (TypeA | TypeA | ? string $x) {} when that space after ? is already handled?

[julienfalque]

? is not allowed when using union types with | but I see your point. I don't have a better suggestion for now.

[kubawerlos]

Let's go with TypesSpacesFixer for now then.

[nicolas-grekas]

I just ran this PR on branch 6.0 of symfony/symfony, all went well!
Can't wait ;)

[nicolas-grekas]

Hum, on second try, it looks like this doesn't fix past the first argument.
After I added spaces, I have this kind of diff when I try to remove the spaces again with the rule:

-    public function trans(string|\Stringable|TranslatableInterface|null $message, array|string $arguments = [], string $domain = null, string $locale = null, int $count = null): string
+    public function trans(string|\Stringable|TranslatableInterface|null $message, array | string $arguments = [], string $domain = null, string $locale = null, int $count = null): string

[kubawerlos]

@nicolas-grekas I've found the reason: #5799 - can you review that, please?

[SpacePossum]

looks very nice :)
little todo list

• rebase and squash my commit
• wait for TypeAlternationTransformer - fix for multiple function parameters #5799 to be merged
• add unit tests that currently will fail because of issue above
• wait for CI to be green with the new tests, merge and ship

[nicolas-grekas]

#5799 is now merged ;)

[kubawerlos]

@SpacePossum all done

[keradus]

Thank you @kubawerlos.

[sebastianbergmann]

Thank you, @kubawerlos and @keradus.

[sidigi]

[ 'types_spaces' => ['space' => 'single']]

not worked for me

[SpacePossum]

@sidigi can you report a new issue as to properly track it? please fill out the issue template when doing so, thanks!