Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(config): change set's name #5771

Merged
merged 1 commit into from
Jun 27, 2021
Merged

doc(config): change set's name #5771

merged 1 commit into from
Jun 27, 2021

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Jun 15, 2021

The PSR12 set exists (https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/3.0/src/RuleSet/Sets/PSR12Set.php), but here we say:

The example below will add two rules to the default list of PSR2 set rules.

Which is wrong.
I've fixed the set to PSR2, but maybe you want to use PSR12 instead.

Let me know!

@julienfalque
Copy link
Member

maybe you want to use PSR12 instead.

Yeah I would rather keep PSR-12 which supersedes PSR-2 :)

@Kocal
Copy link
Contributor Author

Kocal commented Jun 15, 2021

Done :)

@coveralls
Copy link

coveralls commented Jun 15, 2021

Coverage Status

Coverage remained the same at 92.164% when pulling f888d66 on Kocal:patch-1 into 1dc0f21 on FriendsOfPHP:3.0.

@kubawerlos kubawerlos added the RTM Ready To Merge label Jun 16, 2021
@kubawerlos kubawerlos added this to the 3.0.1 milestone Jun 21, 2021
@keradus keradus removed the RTM Ready To Merge label Jun 27, 2021
@keradus
Copy link
Member

keradus commented Jun 27, 2021

Thank you @Kocal.

@keradus keradus merged commit db19e05 into PHP-CS-Fixer:3.0 Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants