Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: update PHPStan #5789

Merged
merged 1 commit into from
Jul 17, 2021
Merged

DX: update PHPStan #5789

merged 1 commit into from
Jul 17, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Jul 5, 2021

I wonder if we should drop a caret from composer.json to avoid such surprises as the needed update is related to new PHPStan version.

// cc @keradus @SpacePossum @julienfalque

@kubawerlos kubawerlos changed the title Update PHPStan DX: update PHPStan Jul 5, 2021
@coveralls
Copy link

coveralls commented Jul 5, 2021

Coverage Status

Coverage remained the same at 91.572% when pulling 8c7af2a on kubawerlos:update-phpstan into bddb80c on FriendsOfPHP:2.19.

@kubawerlos kubawerlos changed the base branch from 3.0 to 2.19 July 5, 2021 15:41
@julienfalque
Copy link
Member

Yep, we should drop it and use an exact version (or commit compose.lock) so we don't get new errors randomly reported as new PHPStan versions are released. I would even apply this reasoning to all the tools we use (when possible).

@kubawerlos
Copy link
Contributor Author

Let's go with PHPStan for now as it's the only one making troubles.

@julienfalque julienfalque added the RTM Ready To Merge label Jul 7, 2021
@keradus keradus added this to the 2.19.1 milestone Jul 17, 2021
@keradus keradus removed the RTM Ready To Merge label Jul 17, 2021
@keradus
Copy link
Member

keradus commented Jul 17, 2021

Thank you @kubawerlos.

@keradus keradus merged commit a17bb60 into PHP-CS-Fixer:2.19 Jul 17, 2021
@kubawerlos kubawerlos deleted the update-phpstan branch July 17, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants