NoBlankLinesAfterPhpdoc - Add T_NAMESPACE in array of forbidden successors

[paulbalandan]

Fixes #5111

When used, no_blank_lines_after_phpdoc removes the whitespace between the file-level doc-block and the namespace declaration. This should not be the case as namespaces are not considered structural elements that can be documented with doc-blocks. Besides, the file-level doc-block belongs to the file and NOT on the namespace.

See more: https://docs.phpdoc.org/3.0/guide/getting-started/what-is-a-docblock.html

[SpacePossum]

Hi and thanks for your PR!

Looking good already. Could you adjust the test to only test the single issue here, maybe like:

    public function testWhitespaceInDocBlockAboveNamespaceIsNotTouched()
    {
        $expected = '<?php
/**
 * This is a file-level docblock.
 */

namespace Foo\Bar\Baz;
';
        $this->doTest($expected);
    }

Thanks!

[coveralls]

Coverage remained the same at 91.561% when pulling e4dd5a6 on paulbalandan:no-blank-line-after-phpdoc into d7c4564 on FriendsOfPHP:2.19.

[keradus]

@paulbalandan CI is failing for proposed changes

[paulbalandan]

@keradus or @SpacePossum , is it an acceptable fix to just remove the integration of the fixer against single_blank_line_after_namespace? Before this PR, no_blank_lines_after_phpdoc considers T_NAMESPACE as documentable that's why it gets an integration/priority check with single_blank_line_after_namespace. Now that this skips T_NAMESPACE, I think the integration/priority checks should be dropped too.

[keradus]

if there is no longer priority conflict between those two rules anymore, move test from Integration/priority/ to Integration/misc and drop tests/AutoReview/FixerFactoryTest.php:143: [$fixers['no_blank_lines_after_phpdoc'], $fixers['single_blank_line_before_namespace']] row

[paulbalandan]

I have fixed the integration failure. Not sure if the removal of the priority comment in SingleBlankLineBeforeNamespace is warranted.

[keradus]

please avoid squashing the commits in future. now, I have no clue what are the newest changes and have to review from scratch :(

[keradus]

Not sure if the removal of the priority comment (...)

we have tests for it. if CI is happy, all good

[keradus]

Thank you @paulbalandan.