Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPStan to 0.12.92 #5808

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Update PHPStan to 0.12.92 #5808

merged 1 commit into from
Jul 29, 2021

Conversation

kubawerlos
Copy link
Contributor

Report after update:

 ------ --------------------------------------------------------------------------------------------
  Line   src/Tokenizer/Token.php
 ------ --------------------------------------------------------------------------------------------
  81     Result of && is always false.
  81     Strict comparison using === between '' and non-empty-string will always evaluate to false.
 ------ --------------------------------------------------------------------------------------------

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0009%) to 91.572% when pulling 44707a4 on kubawerlos:update-phpstan-0.12.92 into b15ab5f on FriendsOfPHP:2.19.

@julienfalque julienfalque added the RTM Ready To Merge label Jul 18, 2021
@kubawerlos kubawerlos added this to the 2.19.1 milestone Jul 18, 2021
keradus
keradus reviewed Jul 29, 2021
View reviewed changes
src/Tokenizer/Token.php
@@ -77,10 +77,6 @@ public function __construct($token)
$this->isArray = true;
$this->id = $token[0];
$this->content = $token[1];

if ($token[0] && '' === $token[1]) {
throw new \InvalidArgumentException('Cannot set empty content for id-based Token.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we even have same exception msg few lines above ;d

@keradus keradus removed the RTM Ready To Merge label Jul 29, 2021
@keradus
Copy link
Member

keradus commented Jul 29, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 99375f3 into PHP-CS-Fixer:2.19 Jul 29, 2021
@kubawerlos kubawerlos deleted the update-phpstan-0.12.92 branch July 30, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @keradus @julienfalque