-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhpdocTypesOrderFixer: fix for array shapes #5835
Merged
keradus
merged 1 commit into
PHP-CS-Fixer:3.0
from
werlos:fix_PhpdocTypesOrderFixer_array_shapes
Aug 3, 2021
Merged
PhpdocTypesOrderFixer: fix for array shapes #5835
keradus
merged 1 commit into
PHP-CS-Fixer:3.0
from
werlos:fix_PhpdocTypesOrderFixer_array_shapes
Aug 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
approved these changes
Aug 3, 2021
Thank you @kubawerlos. |
Thanks for fixing this 👏 |
This was referenced Aug 3, 2021
I think there's still an issue with 3.0.2: - * @var Closure(Iterator<TKey, T>): Generator<TKey, T> $callback
+ * @var Closure(Iterator<TKey, <|T>): Generator|TKey, T> $callback |
drupol
added a commit
to drupol/phpcsfixer-configs-php
that referenced
this pull request
Aug 4, 2021
Related but slightly different syntax also causes issues: - * @param null|callable(array<string>): array<string, T> $computeCallback
+ * @param null|callable(array<string>): array|<|string, T> $computeCallback |
Thanks for reporting! Can you guys check there is a new open bug issue for these cases? it is kinda hard keep track with closed issues/PR's |
I think it's #5850 ... Will post there too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5798
closes #5833
As an extra it will "work" for broken types such as
array<string}
orarray{string>
.