PhpdocTagTypeFixer - must not remove inlined tags within other tags #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
force-pushed
the
bugfix/phpdoc_tag_type-inline-see
branch
from
192f8fd
to
907a747
Compare
julienfalque
reviewed
Aug 5, 2021
| @@ -348,6 +348,36 @@ public function provideFixCases() | |||
| '<?php | |||
| /** | |||
| * @return array{0: float, 1: int} | |||
| */', | |||
There was a problem hiding this comment.
Could you add a case like the failing one you reported in #5815, i.e. @internal ending with a {@see tag}?
boesing
force-pushed
the
bugfix/phpdoc_tag_type-inline-see
branch
from
907a747
to
c818712
Compare
|
@juliendufresne yah, was thinking the same yesterday evening but was too tired. Added now, thanks for the reminder! |
julienfalque
approved these changes
Aug 5, 2021
kubawerlos
approved these changes
Aug 28, 2021
keradus
changed the title
PhpdocTagTypeFixer must not remove inlined tags within other tags
keradus
force-pushed
the
bugfix/phpdoc_tag_type-inline-see
branch
from
c818712
to
af78040
Compare
|
Thank you @boesing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5815