Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalNamespaceImportFixer - fix for attributes imported as constants #5855

Merged
merged 1 commit into from
Aug 29, 2021
Merged

GlobalNamespaceImportFixer - fix for attributes imported as constants #5855

merged 1 commit into from
Aug 29, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Aug 5, 2021 •
edited

Fixes #5812

@kubawerlos kubawerlos mentioned this pull request Aug 5, 2021
Merged
keradus added a commit that referenced this pull request Aug 28, 2021
@keradus
minor #5856 Add AttributeAnalyzer (kubawerlos)
486b3de 
This PR was squashed before being merged into the 3.0 branch.

Discussion
----------

Add AttributeAnalyzer

Needed for #5809, #5855 and #5909.

Commits
-------

2bd7b63 Add AttributeAnalyzer
@coveralls
Copy link

coveralls commented Aug 28, 2021 •
edited

Coverage Status

Coverage increased (+0.0008%) to 92.283% when pulling 21d6643 on kubawerlos:fix_GlobalNamespaceImportFixer into ca8aea7 on FriendsOfPHP:3.0.

@kubawerlos kubawerlos marked this pull request as ready for review August 28, 2021 18:41
@keradus
Copy link
Member

keradus commented Aug 29, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 12b2a96 into PHP-CS-Fixer:3.0 Aug 29, 2021
@keradus keradus added this to the 3.0.3 milestone Aug 29, 2021
@kubawerlos kubawerlos deleted the fix_GlobalNamespaceImportFixer branch August 29, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

Attributes get imported as constants
3 participants
@kubawerlos @coveralls @keradus