Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AttributeAnalyzer #5856

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Add AttributeAnalyzer #5856

merged 1 commit into from
Aug 28, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Aug 5, 2021 •
edited

Needed for #5809, #5855 and #5909.

This was referenced Aug 5, 2021
Merged
Merged
@coveralls
Copy link

coveralls commented Aug 5, 2021 •
edited

Coverage Status

Coverage increased (+0.005%) to 92.283% when pulling 2bd7b63 on kubawerlos:add_AttributeAnalyzer into c172d22 on FriendsOfPHP:3.0.

@kubawerlos
Copy link
Contributor Author

@SpacePossum I'm counting on your creativity with test cases.

@davidbyoung
Copy link

Thanks for the PR! Any update on when this might get merged in so that #5809 can get merged in? I can't upgrade to v3 in my PHP 8.0 project until they're merged because of the issue with attributes being accidentally marked as global functions (#5722). Thanks again.

@kubawerlos
Copy link
Contributor Author

@davidbyoung it needs to be reviewed, feel invited to do it.

davidbyoung
davidbyoung reviewed Aug 12, 2021
View reviewed changes
Copy link

@davidbyoung davidbyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions about testing some more edge cases

tests/Tokenizer/Analyzer/AttributeAnalyzerTest.php Outdated Show resolved Hide resolved
tests/Tokenizer/Analyzer/AttributeAnalyzerTest.php Outdated Show resolved Hide resolved
@davidbyoung
Copy link

Good morning. Is there anything outstanding that we need for this PR to be merged in besides being updated to latest?

@kubawerlos kubawerlos mentioned this pull request Aug 28, 2021
Closed
keradus
keradus approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively, expecting more cases to be potentially discovered in upcoming PRs

@keradus keradus added this to the 3.0.3 milestone Aug 28, 2021
@keradus
Copy link
Member

keradus commented Aug 28, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 486b3de into PHP-CS-Fixer:3.0 Aug 28, 2021
@kubawerlos kubawerlos deleted the add_AttributeAnalyzer branch August 28, 2021 14:32
@kubawerlos
Copy link
Contributor Author

tentatively, expecting more cases to be potentially discovered in upcoming PRs

I hope not ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

@davidbyoung davidbyoung davidbyoung approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @davidbyoung @keradus