Various fixes #5859
Merged
Various fixes #5859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubawerlos
commented
Aug 6, 2021
|
|
||
| if ($fixer instanceof FixerInterface) { |
There was a problem hiding this comment.
The whole fix here is simply removing this if condition as $fixer is type-hinted to be FixerInterface.
There was a problem hiding this comment.
hehe, i remember we were introducing the FixerInterface and not each of 200+ rules were yet following it. good old times
julienfalque
approved these changes
Aug 6, 2021
SpacePossum
approved these changes
Aug 6, 2021
|
Thank you @kubawerlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues reported by
phpstan/phpstan-strict-rules(which will be added in separate PR as it reports over 400 other issues).