Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassDefinitionFixer - PSR12 for anonymous class #5877

Merged
merged 1 commit into from
Aug 28, 2021
Merged

ClassDefinitionFixer - PSR12 for anonymous class #5877

merged 1 commit into from
Aug 28, 2021

Conversation

SpacePossum
Copy link
Contributor

Adds PSR12 support for anonymous class notation with a space following new class, like new class (1,2) {} (note that new class {} is currently already covered)

Closes: #5463 (comment)
Also reported here loophp/collection#102 (comment) (cc @drupol )
Closes one of the points here #4502
New feature so targets master, no BC break, new behavior through configuration (by default configuration acts the same)

@coveralls
Copy link

coveralls commented Aug 13, 2021

Coverage Status

Coverage increased (+0.005%) to 92.226% when pulling 4d84a83 on SpacePossum:master_ClassDefinitionFixer_PSR12 into 676db92 on FriendsOfPHP:master.

@drupol
Copy link
Contributor

drupol commented Aug 14, 2021

Cool! Looking forward for this :)

@kubawerlos
Copy link
Contributor

Cool! Looking forward for this :)

Don't look, make a review :)

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kubawerlos kubawerlos added the RTM Ready To Merge label Aug 28, 2021
@keradus keradus added this to the 3.1.0 milestone Aug 28, 2021
@keradus keradus mentioned this pull request Aug 28, 2021
10 tasks
@keradus keradus removed the RTM Ready To Merge label Aug 28, 2021
@keradus
Copy link
Member

keradus commented Aug 28, 2021

Thank you @SpacePossum.

@keradus keradus merged commit 90490a6 into PHP-CS-Fixer:master Aug 28, 2021
@keradus keradus deleted the master_ClassDefinitionFixer_PSR12 branch August 28, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants