-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX: Use "yield from" in tests #5905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue we should extract conditional cases into dedicated providers with @require
annotations, but this can be done later.
i'm open to discuss how to have conditional tests existing, but IMHO it's good value to see some tests were skipped due to missing requirements. it;s different to say " 100 / 100 tests passed" vs "100 / 150 tests passed and 50 could not be executed due to not fulfilled requirements" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyway, good cleanup
Thank you @kubawerlos. |
what I would REALLY like is to have a way to get reported tests that are skipped in every PHP version we support (like the removed one with |
The scenario is almost always the same, huge array
$tests
and theforeach
withyield
and someif
after: