Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ClassKeywordRemoveFixer #5914

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Deprecate ClassKeywordRemoveFixer #5914

merged 1 commit into from
Aug 29, 2021

Conversation

kubawerlos
Copy link
Contributor

As requested in https://gitter.im/PHP-CS-Fixer/Lobby?at=612a3c675b92082de16f62b3

Even when the fixer was introduced it was considered "harmful and encouraging bad habits".

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 92.312% when pulling 1ab48e2 on kubawerlos:deprecate_ClassKeywordRemoveFixer into 0865c64 on FriendsOfPHP:master.

@kubawerlos kubawerlos added this to the 3.1.0 milestone Aug 28, 2021
@keradus keradus removed the RTM Ready To Merge label Aug 29, 2021
@keradus
Copy link
Member

keradus commented Aug 29, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 47d6dd4 into PHP-CS-Fixer:master Aug 29, 2021
@GrahamCampbell
Copy link
Contributor

Nice. 👍

@kubawerlos kubawerlos deleted the deprecate_ClassKeywordRemoveFixer branch August 29, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants