Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoExtraBlankLinesFixer - Improve deprecation message #6051

Merged
merged 1 commit into from
Oct 5, 2021
Merged

NoExtraBlankLinesFixer - Improve deprecation message #6051

merged 1 commit into from
Oct 5, 2021

Conversation

paulbalandan
Copy link
Contributor

Running the new version would give the deprecation message:

Option "use_trait" is deprecated, use the rule `class_attributes_separation` with `elements: trait_import` instead.

but it is not quite evident where that option was used. This proposes to include as well the fixer where the option was used.

@coveralls
Copy link

coveralls commented Oct 5, 2021 •
edited

Coverage Status

Coverage remained the same at 92.817% when pulling 17a2e5c on paulbalandan:improve-deprecation-message into dca212a on FriendsOfPHP:master.

@SpacePossum SpacePossum changed the title Improve deprecation message raised by NoExtraBlankLinesFixer NoExtraBlankLinesFixer - Improve deprecation message Oct 5, 2021
@SpacePossum
Copy link
Contributor

Thank you @paulbalandan.

@SpacePossum SpacePossum merged commit 2f4652f into PHP-CS-Fixer:master Oct 5, 2021
@paulbalandan paulbalandan deleted the improve-deprecation-message branch October 5, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulbalandan @coveralls @SpacePossum @julienfalque